8000 fix(userspace/libsinsp): remove state handling for `PPM_SYSCALL_MKDIR` by terror96 · Pull Request #2480 · falcosecurity/libs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(userspace/libsinsp): remove state handling for PPM_SYSCALL_MKDIR #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

fix(userspace/libsinsp): remove state handling for PPM_SYSCALL_MKDIR #2480

merged 1 commit into from
Jun 16, 2025

Conversation

terror96
Copy link
Contributor

The new driver does not emit PPM_SYSCALL_MKDIR events anymore, and there is no longer need to handle the old version of the mkdir event. This update removes the state handling and adds conversion rules for the scap files.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of #2068.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@terror96
fix(userspace/libsinsp): remove state handling for PPM_SYSCALL_MKDIR
b6bcf58 
The new driver does not emit `PPM_SYSCALL_MKDIR` events anymore, and
there is no longer need to handle the old version of the mkdir event.
This update removes the state handling and adds conversion rules for
the scap files.

Signed-off-by: Tero Kauppinen <tero.kauppinen@est.tech>
@poiana poiana requested review from gnosek and hbrueckner June 16, 2025 12:21
@poiana poiana added the size/M label Jun 16, 2025
@ekoops
Copy link
Contributor
ekoops commented Jun 16, 2025

/milestone 0.22.0

@poiana poiana added this to the 0.22.0 milestone Jun 16, 2025
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     7.42%     -0.45%  [.] sinsp::next
     1.64%     -0.42%  [.] sinsp_evt_filter::sinsp_evt_filter
     2.72%     +0.35%  [.] sinsp_evt::load_params
     0.86%     -0.35%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     5.75%     -0.34%  [.] sinsp_evt::get_type
     1.49%     -0.27%  [.] user_group_updater::user_group_updater
     5.10%     -0.27%  [.] sinsp_thread_manager::find_thread
     0.82%     +0.26%  [.] sinsp::fetch_next_event
     0.71%     -0.22%  [.] sinsp_evt::get_direction
    22.63%     +0.21%  [.] sinsp_thread_manager::create_thread_dependencies

Heap diff from master - unit tests

peak heap memory consumption: -2.03K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -346B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0256         +0.0256           143           147           143           147
BM_sinsp_split_median                                          +0.0241         +0.0242           143           147           143           147
BM_sinsp_split_stddev                                          -0.4613         -0.4574             2             1             2             1
BM_
8000
sinsp_split_cv                                              -0.4748         -0.4709             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0376         +0.0376            55            57            55            57
BM_sinsp_concatenate_paths_relative_path_median                +0.0129         +0.0129            55            55            55            55
BM_sinsp_concatenate_paths_relative_path_stddev                +3.3704         +3.3669             1             4             1             4
BM_sinsp_concatenate_paths_relative_path_cv                    +3.2121         +3.2087             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0419         -0.0420            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0418         -0.0418            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.0940         +0.0961             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.1419         +0.1441             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0648         +0.0647            57            61            57            61
BM_sinsp_concatenate_paths_absolute_path_median                +0.0778         +0.0777            57            62            57            62
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.4709         +1.4719             1             3             1             3
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.3205         +1.3216             0             0             0             0

@codecov Codecov
Copy link
codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (883c697) to head (b6bcf58).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2480      +/-   ##
==========================================
- Coverage   77.89%   77.88%   -0.01%     
==========================================
  Files         251      251              
  Lines       31078    31071       -7     
  Branches     4653     4653              
==========================================
- Hits        24208    24201       -7     
  Misses       6870     6870
Flag Coverage Δ
libsinsp 77.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops
Copy link
Contributor
ekoops commented Jun 16, 2025

/approve

@poiana poiana added the lgtm label Jun 16, 2025
@poiana
Copy link
Contributor
poiana commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, terror96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor
poiana commented Jun 16, 2025

LGTM label has been added.

Git tree hash: 36d20a617d9a507aaa7fb922abb7ac95f2545386

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Jun 16, 2025
@poiana poiana merged commit 8aad951 into falcosecurity:master Jun 16, 2025
57 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Jun 16, 2025
@terror96 terror96 deleted the cleanup-ppme-syscall-mkdir branch June 17, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@ekoops ekoops ekoops approved these changes

@gnosek gnosek Awaiting requested review from gnosek

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@leogr leogr

@ekoops ekoops

Labels
approved area/libscap-engine-savefile area/libsinsp area/tests dco-signoff: yes kind/feature New feature or request lgtm release-note-none size/M
Projects
Falco Roadmap
Status: Done
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@terror96 @ekoops @poiana @leogr
0