8000 feat: add `PPME_SYSCALL_IOCTL_3_E` params to `PPME_SYSCALL_IOCTL_3_X` by ekoops · Pull Request #2464 · falcosecurity/libs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add PPME_SYSCALL_IOCTL_3_E params to PPME_SYSCALL_IOCTL_3_X #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

feat: add PPME_SYSCALL_IOCTL_3_E params to PPME_SYSCALL_IOCTL_3_X #2464

merged 1 commit into from
Jun 10, 2025

Conversation

ekoops
Copy link
Contributor
@ekoops ekoops commented Jun 10, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of #2427.

It adds enter events parameters to PPME_SYSCALL_IOCTL_3_X event definition and aligns all three kernel drivers to the new definition. Moreover, it adds parsing tests for poll events.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@ekoops
feat: add PPME_SYSCALL_IOCTL_3_E params to PPME_SYSCALL_IOCTL_3_X
6812d2c 
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@poiana poiana requested review from hbrueckner and Molter73 June 10, 2025 10:12
@ekoops ekoops mentioned this pull request Jun 10, 2025
Open
@ekoops
Copy link
Contributor Author
ekoops commented Jun 10, 2025

/milestone 0.22.0

@poiana poiana added this to the 0.22.0 milestone Jun 10, 2025
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

    27.16%     -1.95%  [.] sinsp_thread_manager::create_thread_dependencies
     1.30%     +0.47%  [.] can_query_os_for_thread_info
     2.59%     -0.46%  [.] sinsp_thread_manager::get_thread_ref
     1.18%     +0.43%  [.] user_group_updater::~user_group_updater
     1.03%     +0.42%  [.] user_group_updater::user_group_updater
     0.98%     -0.41%  [.] sinsp_evt::get_direction
     2.79%     -0.38%  [.] gzfile_read
     5.18%     +0.34%  [.] sinsp_parser::reset
     0.72%     +0.31%  [.] sinsp_parser::event_cleanup
     3.73%     -0.26%  [.] next_event_from_file

Heap diff from master - unit tests

peak heap memory consumption: -1.12K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -150B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benc 8000 hmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0140         +0.0141           146           149           146           149
BM_sinsp_split_median                                          +0.0113         +0.0114           147           148           147           148
BM_sinsp_split_stddev                                          +0.5236         +0.5227             1             2             1             2
BM_sinsp_split_cv                                              +0.5026         +0.5015             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0083         -0.0082            62            62            62            62
BM_sinsp_concatenate_paths_relative_path_median                -0.0139         -0.0138            63            62            62            62
BM_sinsp_concatenate_paths_relative_path_stddev                +2.1429         +2.1372             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +2.1690         +2.1630             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0188         +0.0189            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0152         +0.0153            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.9147         +0.9151             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.8794         +0.8797             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0459         +0.0460            63            66            63            66
BM_sinsp_concatenate_paths_absolute_path_median                +0.0632         +0.0633            62            66            62            66
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3881         -0.3877             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.4149         -0.4146             0             0             0             0

@codecov Codecov
Copy link
codecov bot commented Jun 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (2a838b7) to head (6812d2c).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2464      +/-   ##
==========================================
+ Coverage   77.82%   77.84%   +0.01%     
==========================================
  Files         247      248       +1     
  Lines       30994    31017      +23     
  Branches     4661     4661              
==========================================
+ Hits        24121    24144      +23     
  Misses       6873     6873
Flag Coverage Δ
libsinsp 77.84% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops
Copy link
Contributor Author
ekoops commented Jun 10, 2025

arm64:

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

amd64:

8000
KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

FedeDP
FedeDP approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor
@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

@poiana
Copy link
Contributor
poiana commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor
poiana commented Jun 10, 2025

LGTM label has been added.

Git tree hash: b9b083423642cfa7211d9b36ef4a21c53d300094

@FedeDP
Copy link
Contributor
FedeDP commented Jun 10, 2025

/unhold

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Jun 10, 2025
@poiana poiana merged commit 42182ff into falcosecurity:master Jun 10, 2025
57 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Jun 10, 2025
@ekoops ekoops deleted the ekoops/convert-ioctl branch June 10, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnosek gnosek gnosek approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@Molter73 Molter73 Awaiting requested review from Molter73

Assignees

@gnosek gnosek

@FedeDP FedeDP

Labels
approved area/driver-bpf area/driver-kmod area/driver-modern-bpf area/libscap-engine-savefile dco-signoff: yes kind/feature New feature or request kind/test lgtm release-note-none size/XL
Projects
Falco Roadmap
Status: Done
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @gnosek
0