8000 Routes arrays not correctly merging · Issue #1 · fabrix-app/spool-router · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Routes arrays not correctly merging #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scott-wyatt opened this issue Jul 16, 2018 · 0 comments
Closed

Routes arrays not correctly merging #1

scott-wyatt opened this issue Jul 16, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@scott-wyatt
Copy link
Contributor

Spools that provide routes are not being properly merged with the master list of routes.

Reproduce:
spoolA { config: { routes: []}}
spoolB { config: { routes: []}}
app { config: { routes: []}}

Should result in:

app.routes = app.config.routes = [, ,]

Instead, it is randomly dropping routes.
@scott-wyatt scott-wyatt added the bug Something isn't working label Jul 16, 2018
@scott-wyatt scott-wyatt mentioned this issue Jul 17, 2018
Merged
scott-wyatt added a commit that referenced this issue Jul 17, 2018
@scott-wyatt
Merge pull request #2 from fabrix-app/v1.1
19bdd9f 
[feat] Route Objects fixes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scott-wyatt
0