8000 Code Z118 (Jugoslavia) not recognised, in general file countries.json don't manage deleted countries · Issue #36 · fabiocaccamo/python-codicefiscale · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Code Z118 (Jugoslavia) not recognised, in general file countries.json don't manage deleted countries #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
giobber opened this issue Nov 25, 2022 · 8 comments
Closed

Code Z118 (Jugoslavia) not recognised, in general file countries.json don't manage deleted countries #36

giobber opened this issue Nov 25, 2022 · 8 comments
Assignees
@fabiocaccamo
Labels
bug Something isn't working enhancement New feature or request

Comments

@giobber
Copy link
giobber commented Nov 25, 2022

Python version
3.10

Package version
I'm installing main branch with pip

Current behavior (bug description)
A Fiscal Code with birthplace code set as Z118 (code for ex-country Jugoslavia) are marked as invalid when using codicefiscale.is_valid() function. When I open up the countries.json file I cannot find that code inside but I notice that all codes have as date_created value "01/01/1900 00:00:00" and date_deleted ""
I don't know if this is the desired behaviour, but I think there is no management of deleted foreign country.
In my code I've added an exception for that code (It's only one person in a database) but I want to inform about this behaviour

Expected behavior
CF with code Z118 should be recognised as a Foreign Person born in a deleted country
@giobber giobber added the bug Something isn't working label Nov 25, 2022
@fabiocaccamo
Copy link
Owner

@giobber countries data is automatically updated every week from this data source:
https://www.anagrafenazionale.interno.it/wp-content/uploads/2021/03/tabella_2_statiesteri.xlsx

If there are some missing countries the only thing that could be done is to post-process the data adding some entries at the end of the update workflow.

I'm sure that there are many other cases like this one, do you have a better data-source that could be used for retrieving more accurate countries info?

@giobber
Copy link
Author
giobber commented Nov 27, 2022

I've searched for my case on google and i found the history of code for Serbia in this site

The site of Agenzia delle Entrate seem to be the right source, but the only page I found instead of data, contains a download for a .exe file...And I use linux...

Istat at this link contains interesting links...but today are not working (yesterday from phone worked, so maybe is a temporary issue)

Searching the first site I found a section where they explain various issues the had in fixing foreign countries data taken from Agenzia delle Entrate. At this link they explain everithing and there is a download link for data in xls format

@fabiocaccamo fabiocaccamo added the enhancement New feature or request label Nov 28, 2022
@fabiocaccamo fabiocaccamo moved this to Todo in Open Source Dec 1, 2022
@fabiocaccamo
Copy link
Owner
fabiocaccamo commented Dec 11, 2022 •
edited
Loading

@giobber I finally had some time for checking the data sources you linked:

I've searched for my case on google and i found the history of code for Serbia in this site

Nice info, but not so useful for automating data updates.

Istat at this link contains interesting links...but today are not working (yesterday from phone worked, so maybe is a temporary issue)

Good resource, especially this file, checking the data there is a problem: there is not the precise date (only the year) when the country has been "removed".

Frankly I would use the Istat data-source, but it's incomplete. :(

Searching the first site I found a section where they explain various issues the had in fixing foreign countries data taken from Agenzia delle Entrate. At this link they explain everithing and there is a download link for data in xls format

Here there are certainly more detailed info, but if you check for "Iugoslavia" there are six rows with different dates (one row for each new country), it's a little bit confusing and I don't want to depend on a site that is not an official institution.

@WaYdotNET
Copy link

missing also Z135 http://www.elesh.it/storiastati/storia_stato.asp?codcat=Z135

@fabiocaccamo
Copy link
Owner

@WaYdotNET thanks for reporting it.

fabiocaccamo added a commit that referenced this issue Apr 8, 2023
@fabiocaccamo
Manage correctly deleted countries. #36
68c3edb
@fabiocaccamo
Copy link
Owner

@giobber @WaYdotNET you can upgrade to 0.8.0 version.

@github-project-automation github-project-automation bot moved this from Todo to Done in Open Source Apr 8, 2023
@WaYdotNET
Copy link

Thx @fabiocaccamo

@fabiocaccamo
Copy link
Owner

Elenco-Paesi-esteri-cessati.csv
6387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabiocaccamo fabiocaccamo

Labels
bug Something isn't working enhancement New feature or request
Projects
Open Source
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WaYdotNET @fabiocaccamo @giobber
0