8000 add ENDOOM support (from Chocolate Doom) by rfomin · Pull Request #184 · fabiangreffrath/woof · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add ENDOOM support (from Chocolate Doom) #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 4, 2021

Conversation

rfomin
Copy link
Collaborator
@rfomin rfomin commented Apr 29, 2021

Add libtextscreen for future use in multiplayer gui and ENDOOM.

@rfomin
Copy link
Collaborator Author
rfomin commented Aug 27, 2021

So, do we merge this? I like to make ENDOOM support and net_gui for a multiplayer branch.

@fabiangreffrath
Copy link
Owner

Let's please only add as much of libtextscreen as we need to render the ENDOOM screen (cf. Pr+). Also, there is a WIP branch available to render ENDOOM in the same window as the game, but this is still flawed and unfinished.
chocolate-doom/chocolate-doom#1331

@rfomin
Copy link
Collaborator Author
rfomin commented Aug 27, 2021

Don't want to use it for multiplayer? An alternative is some kind of cross-platform GUI library, but it is much more cumbersome. I personally like libtextscreen, it will also match the Choco family.
We can also try to create an in-game GUI for multiplayer, but for a niche feature it takes a lot of effort.

ENDOOM in the same window as the game

Yes, I want to try that.

@fabiangreffrath
Copy link
Owner

I consider multiplayer an absolute niche for a port like Woof. Thus, I don't see a huge problem in not providing a GUI but requiring the interested user to type woof -connect 192.168.0.100 or whatever.

@rfomin
Copy link
Collaborator Author
rfomin commented Aug 27, 2021

I played multiplayer Woof and Crispy, and little text GUI windows are very helpful. Right now we don't even have console output on Windows. Yes, it is a niche, but a pretty unique one - this is the only port with working Boom/MBF demo compatible multiplayer.

@rfomin rfomin changed the title add libtextscreen from Chocolate Doom add ENDOOM support Oct 31, 2021
@rfomin rfomin changed the title add ENDOOM support add ENDOOM support (from Chocolate Doom) Oct 31, 2021
@rfomin
Copy link
Collaborator Author
rfomin commented Oct 31, 2021

Not sure about linear scaling:
endoom

TXT_SCREEN_H * font->h,
8, 0, 0, 0, 0);

SDL_RenderSetLogicalSize(renderer, screenbuffer->w, screenbuffer->h);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment, please! If there are other parts of this library that you had to change to achieve the current state, please comment them as well.

Source/m_menu.c Outdated
@@ -3624,6 +3625,9 @@ setup_menu_t gen_settings2[] = { // General Settings screen2
{"Default compatibility", S_CHOICE|S_LEVWARN, m_null, G_X,
G_Y4 + general_comp*8, {"default_complevel"}, 0, NULL, default_compatibility_strings},

{"Show ENDOOM", S_YESNO, m_null, G_X,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only want to see ENDOOM for PWADs that provide their own lump, so please turn this into a choice of three: "on", "off", PWAD only".

@fabiangreffrath
Copy link
Owner

Looks pretty complete to me. Ready to merge?

@rfomin
Copy link
Collaborator Author
rfomin commented Nov 4, 2021

Yes, I think it's ready.

@fabiangreffrath fabiangreffrath merged commit 19d3ab0 into fabiangreffrath:master Nov 4, 2021
@rfomin rfomin deleted the textscreen branch November 4, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

343E
2 participants
0