openmp: implement real openmp fork/join model #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e216f81 to
67417a2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
==========================================
+ Coverage 67.60% 67.68% +0.07%
==========================================
Files 71 71
Lines 7811 7887 +76
==========================================
+ Hits 5281 5338 +57
- Misses 2530 2549 +19 ☔ View full report in Codecov by Sentry. |
0d55781 to
6d12053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when we wanted to spawn 10 OpenMP threads, the main executing thread would spawn 10 threads, and wait for their result. In the true OpenMP fork/join model, the parent thread is part of the 10 remaining threads.
The latter logic makes it simpler to implement in terms of SCALE_UP or DIST_CHANGE decisions wrt the planner, so we do so here.