8000 Asio+Beast-based endpoint server by eigenraven · Pull Request #683 · faasm/faasm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Asio+Beast-based endpoint server #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Oct 27, 2022
Merged

Asio+Beast-based endpoint server #683

merged 52 commits into from
Oct 27, 2022

Conversation

eigenraven
Copy link
Collaborator

Update faabric to make use of the asio/beast-based endpoint server. Also fix a missing include in CGroup.cpp.

@csegarragonz
Copy link
Collaborator

Are the dist-tests failures related to this PR?

@eigenraven
Copy link
Collaborator Author

I have to check, it seems the error is with dns resolution, which could be because asio does it differently (or if dist-test-server crashes and doesn't print its logs out in the actions worker):

/usr/local/code/faasm/tests/dist/threads/test_pthreads.cpp:9: FAILED:
due to unexpected exception with message:
  Could not resolve host dist-test-server

@eigenraven
Copy link
Collaborator Author

I can't replicate the crash locally, it seems to come from this call: hostent* record = gethostbyname(hostname.c_str()); which is just the libc DNS resolver. I queued a rerun of dist-tests in case it was a weird failure on actions's side yesterday

@eigenraven
Copy link
Collaborator Author

It also looks like the conan cache is not actually working in the dist-tests runner

@eigenraven
Copy link
Collaborator Author

Found it, it's a asio segmentation fault because I didn't copy over the compiler definition to stop it from using RTTI. I'll push a fix in a minute

@eigenraven
Copy link
Collaborator Author

I have pushed the fix that should work, but locally it doesn't for me - I'm really confused as to why, the crash is in a line that should be defined by a #if !defined(...) and checking the compiler logs that define is passed in the commandline. We'll see if this is just some weird bug with my local setup (though I did do a clean build) or there's something more going on

@eigenraven
Copy link
Collaborator Author

I have to work on some other things right now, so I'll take a break from debugging this, if you want to try to reproduce this locally, try running dist_test_server from the cli container after building it in debug mode - it should crash with a SIGSEGV after a few seconds.

@eigenraven eigenraven mentioned this pull request Oct 18, 2022
Merged
@eigenraven
Checkout code before building tests.
17ca8e2 
Also remove fail-fast from sgx-tests, it only applies to matrix builds.
@eigenraven
Revert "Checkout code before building tests."
e619ae7 
This reverts commit 17ca8e2.
@eigenraven
Checkout code in container jobs manually, as actions/checkout only wo…
9fb0e04 
…rks in GITHUB_WORKSPACE whic
8000
h is a /__w/... path.
@csegarragonz csegarragonz merged commit 212698c into main Oct 27, 2022
@csegarragonz csegarragonz deleted the asio-http-server branch October 27, 2022 09:20
@eigenraven eigenraven mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shillaker Shillaker Shillaker approved these changes

@csegarragonz csegarragonz csegarragonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eigenraven @csegarragonz @Shillaker
0