Fixes for distributed and state tests #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
commented
Mar 4, 2022
| @@ -18,10 +18,10 @@ using namespace faabric::scheduler; | |||
| using namespace WAVM; | |||
|
|
|||
| #define MPI_FUNC(str) \ | |||
| SPDLOG_DEBUG("MPI-{} {}", executingContext.getRank(), str); | |||
| SPDLOG_TRACE("MPI-{} {}", executingContext.getRank(), str); | |||
There was a problem hiding this comment.
These were printing out so much logging information in the dist tests that it was difficult to debug.
Shillaker
commented
Mar 15, 2022
| @@ -219,55 +219,47 @@ interfering with the tests: | |||
| docker-compose down | |||
| ``` | |||
|
|
|||
| Start the distributed tests server: | |||
| Make sure your local setup is built, along with the distributed tests: | |||
There was a problem hiding this comment.
Slight rearrange of these distributed test docs which I found a little confusing before.
Shillaker
commented
Mar 15, 2022
| faabric::Message result = checkMpiFunc("mpi_pi"); | ||
| std::string output = result.outputdata(); | ||
| REQUIRE(faabric::util::startsWith(output, "Pi estimate: 3.1")); | ||
| } |
There was a problem hiding this comment.
Noticed that this wasn't included in tests so I added it for good measure.
csegarragonz
approved these changes
Mar 15, 2022
| @@ -219,55 +219,47 @@ interfering with the tests: | |||
| docker-compose down | |||
| ``` | |||
|
|
|||
| Start the distributed tests server: | |||
| Make sure your local setup is built, along with the distributed tests: | |||
| @@ -3,12 +3,14 @@ | |||
| #include "fixtures.h" | |||
|
|
|||
| #include <faabric/scheduler/Scheduler.h> | |||
| #include <faabric/util/string_tools.h> | |||
|
|
|||
| #define PI_FUNCTION "pi_faasm" | |||
There was a problem hiding this comment.
Very minor, but it feels a bit odd that this is the only function with its name #define-ed and also that it follows a different format than MPI. I would have expected it to be called omp_pi.
Haha yes, wonder how long it will survive for this time 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
demo/pifunction (distributed Pi calculation).This requires these two PRs to be merged in before closing: