8000 Move dev cluster scripts to Invoke tasks by Shillaker · Pull Request #608 · faasm/faasm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move dev cluster scripts to Invoke tasks #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Move dev cluster scripts to Invoke tasks #608

merged 4 commits into from
Mar 4, 2022

Conversation

Shillaker
Copy link
Collaborator
@Shillaker Shillaker commented Mar 3, 2022

It was a bit clunky having the dev cluster stuff in a shell script, so I moved it all to some invoke tasks within the CLI.

Some of these functions only provider a very thin layer around the docker-compose CLI, but given that this is a common entrypoint for new/ unfamiliar users of the system, I think it's ok to put the most common operations in the same place.

@Shillaker Shillaker self-assigned this Mar 3, 2022
@Shillaker Shillaker marked this pull request as ready for review March 3, 2022 15:19
@Shillaker Shillaker requested a review from csegarragonz March 4, 2022 10:20
Copy link
Collaborator
@csegarragonz csegarragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is very nice to have

@Shillaker Shillaker merged commit 970a998 into main Mar 4, 2022
@Shillaker Shillaker deleted the demo branch March 4, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0