8000 Updates to resurrect the Python performance benchmarks by Shillaker · Pull Request #499 · faasm/faasm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updates to resurrect the Python performance benchmarks #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 15, 2021
Merged

Updates to resurrect the Python performance benchmarks #499

merged 11 commits into from
Oct 15, 2021

Conversation

Shillaker
Copy link
Collaborator
@Shillaker Shillaker commented Oct 13, 2021 •
edited
Loading

These were some issues flushed out when trying to run the Python performance benchmarks.

Changes:

  • Add a tests to run one of the Python perf benchmark functions as part of the test suite.
  • Stub a load of networking syscalls that are called the old-school way by some of the dynamically linked libraries (specifically subprocess).
  • Implement waitpid (also called by subprocess).
  • Update to latest cpp and python clients.
  • Update Faasm version.

Note that this build introduces a new version of Faasm, which picks up the latest version of our WAVM fork. This now includes includes this commit: faasm/WAVM@81225ec , which should solve the sporadic stack allocation issues we're seeing in tests at the moment.

@Shillaker Shillaker marked this pull request as draft October 13, 2021 11:52
@Shillaker Shillaker self-assigned this Oct 13, 2021
@Shillaker Shillaker marked this pull request as ready for review October 15, 2021 09:13
@Shillaker Shillaker merged commit 0c129f1 into master Oct 15, 2021
@Shillaker Shillaker deleted the python-perf branch October 15, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csegarragonz csegarragonz csegarragonz approved these changes

Assignees

@Shillaker Shillaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shillaker @csegarragonz
0