8000 Remove unused MessageLocalResult by csegarragonz · Pull Request #338 · faasm/faabric · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove unused MessageLocalResult #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Remove unused MessageLocalResult #338

merged 1 commit into from
Jul 27, 2023

Conversation

csegarragonz
Copy link
Collaborator
@csegarragonz csegarragonz commented Jul 27, 2023

In advance of implementing the planner scheduling, I am cleaning up the Scheduler.h header and have come accross this class that was no longer used.

The class became obsolete when moving setting/getting results to the planner in #317

@csegarragonz csegarragonz self-assigned this Jul 27, 2023
@codecov
Copy link
codecov bot commented Jul 27, 2023

Codecov Report

Merging #338 (96b179c) into main (b7c6872) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   81.85%   82.08%   +0.22%     
==========================================
  Files          98       98              
  Lines        7979     7964      -15     
==========================================
+ Hits         6531     6537       +6     
+ Misses       1448     1427      -21     
Files Changed Coverage Δ
include/faabric/scheduler/Scheduler.h 42.85% <ø> (+21.42%) ⬆️
src/scheduler/Scheduler.cpp 91.86% <ø> (+0.89%) ⬆️

... and 3 files with indirect coverage changes

@csegarragonz csegarragonz merged commit 74b12aa into main Jul 27, 2023
@csegarragonz csegarragonz deleted the remove-mlr branch July 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0