Fix planner k8s deployment
#312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e739b41 to
520f98f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a
k8sdeployment, the advertised IP for the planner, as seen from the workers, is the one corresponding to the kubernetes service we use to expose the planner. This IP is obtained with something likefaabric::util::getIpFromHostname("planner").On the other hand, the IP as reported by the planner (i.e. through
conf.endpointHost) is the IP of the actual pod the planner is running in.We used to check the IPs for equality as a sanity check. We remove the check here and tag a new planner release.
Related to faasm/faasm#748