Add config type annotations to rearrange_sim. #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0mdc
commented
Jan 16, 2025
| @@ -1667,7 +1668,7 @@ class AgentConfig(HabitatBaseConfig): | |||
| max_climb: float = 0.2 | |||
| max_slope: float = 45.0 | |||
| grasp_managers: int = 1 | |||
| sim_sensors: Dict[str, SimulatorSensorConfig] = field(default_factory=dict) | |||
There was a problem hiding this comment.
This field has a bad smell.
When refactoring sensors, we should revisit how users define their sensors. If you look just above, you'll notice that framework-level subclasses were created for application-level code.
We should aim to use composition rather than inheritance to define sensors.
0mdc
commented
Jan 16, 2025
|
|
||
| @contextmanager | ||
| def read_write(config: "Container") -> Generator[Node, None, None]: | ||
| def read_write(config: Any) -> Generator[Node, None, None]: |
There was a problem hiding this comment.
We should probably avoid using this altogether.
Changing configs mid-execution contributes to the complexity explosion we're experiencing, and drives us away from a data-driven paradigm.
0mdc
commented
Jan 16, 2025
|
|
||
| def overwrite_config( | ||
| config_from: DictConfig, | ||
| config_from: Any, |
There was a problem hiding this comment.
Same comment as above.
0mdc
commented
Jan 16, 2025
aclegg3
reviewed
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This changeset annotates the
rearrange_simconfig types to provide type annotations for configs.How Has This Been Tested
CI
Types of changes
Checklist