Remove an Outdated Description in INSTALL.md #2391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdouze has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
BZO95
added a commit
to BZO95/faiss
that referenced
this pull request
Apr 10, 2025
Summary: According to [`CMakeLists.txt`](https://github.com/facebookresearch/faiss/blob/442d9f4a2d43e2ada6423e8e4e3414131dea849d/CMakeLists.txt#L20), current `faiss` doesn't recognize `sse4` as `FAISS_OPT_LEVEL` . I've read `CMakeLists.txt`s and confirmed that (current `faiss` treats `sse4` as same as `generic`), so this PR removes the description of this outdated option from `INSTALL.md` . This PR contains only document update, so this doesn't affect the software behavior. Pull Request resolved: facebookresearch/faiss#2391 Reviewed By: alexanderguzhva Differential Revision: D39167022 Pulled By: mdouze fbshipit-source-id: ff36fc5167c4d2e8d16206061624a8ba2890b4b7
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Apr 10, 2025
Summary: According to [`CMakeLists.txt`](https://github.com/facebookresearch/faiss/blob/442d9f4a2d43e2ada6423e8e4e3414131dea849d/CMakeLists.txt#L20), current `faiss` doesn't recognize `sse4` as `FAISS_OPT_LEVEL` . I've read `CMakeLists.txt`s and confirmed that (current `faiss` treats `sse4` as same as `generic`), so this PR removes the description of this outdated option from `INSTALL.md` . This PR contains only document update, so this doesn't affect the software behavior. Pull Request resolved: facebookresearch#2391 Reviewed By: alexanderguzhva Differential Revision: D39167022 Pulled By: mdouze fbshipit-source-id: ff36fc5167c4d2e8d16206061624a8ba2890b4b7
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Apr 10, 2025
Summary: According to [`CMakeLists.txt`](https://github.com/facebookresearch/faiss/blob/442d9f4a2d43e2ada6423e8e4e3414131dea849d/CMakeLists.txt#L20), current `faiss` doesn't recognize `sse4` as `FAISS_OPT_LEVEL` . I've read `CMakeLists.txt`s and confirmed that (current `faiss` treats `sse4` as same as `generic`), so this PR removes the description of this outdated option from `INSTALL.md` . This PR contains only document update, so this doesn't affect the software behavior. Pull Request resolved: facebookresearch#2391 Reviewed By: alexanderguzhva Differential Revision: D39167022 Pulled By: mdouze fbshipit-source-id: ff36fc5167c4d2e8d16206061624a8ba2890b4b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
CMakeLists.txt, currentfaissdoesn't recognizesse4asFAISS_OPT_LEVEL.I've read
CMakeLists.txts and confirmed that (currentfaisstreatssse4as same asgeneric), so this PR removes the description of this outdated option fromINSTALL.md.This PR contains only document update, so this doesn't affect the software behavior.