8000 Use vswhere to find MSBuild; add VS2022 support by ManuelBlanc · Pull Request #3987 · facebook/zstd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use vswhere to find MSBuild; add VS2022 support #3987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

ManuelBlanc
Copy link
Contributor

See:
https://github.com/microsoft/vswhere/wiki/Find-MSBuild


What problems does this PR solve?

  • Adds support for Visual Studio 17 2022.
  • Adds support for the "Build Tools" editions (available in Visual Studio 15 2017 and up).
  • Simplifies adding support for future Visual Studio versions.

Testing done

Tested with VS2017 Build Tools, VS2019 Professional and VS2022 Community. Code path for older versions is unchanged.

Copy link
Contributor
@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@Cyan4973 Cyan4973 merged commit 80a9a2d into facebook:dev Mar 27, 2024
@ManuelBlanc ManuelBlanc deleted the msbuild_vswhere branch April 5, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0