-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Implement more gzip compatibility (#3037) #3059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These options should be documented in the CLI help text and in the man page. Can you add descriptions?
(If you'd prefer we do that part, we can add them in a follow-up PR.)
-n --no-name is the current behavior already, so we can implement this as a noop. --best is an alias for -9 in gzip add basic cli tests.
479ef20 to
e653e97
Compare
|
@felixhandte Okay, wasn't sure as these options are just for better gzip compatibility and not exposed in standard zstd cli. anyway added. |
|
is there anything I can do to move this forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder. Let's ship it!
-n --no-name is the current behavior already, so we can implement
this as a noop.
--best is an alias for -9 in gzip
add basic cli tests.