8000 Refactor dictionary matchfinder index safety check by Federico-Maresca · Pull Request #4039 · facebook/zstd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor dictionary matchfinder index safety check #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

Refactor dictionary matchfinder index safety check #4039

merged 1 commit into from
May 29, 2024

Conversation

Federico-Maresca
Copy link
Contributor

As outlined in #3334 by @embg this is a code refactoring to improve readability on if statements for dictionary matchfinders that share the same check.

@facebook-github-bot
Copy link

Hi @Federico-Maresca!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Cyan4973
Copy link
Contributor
Cyan4973 commented May 9, 2024

I like it, I think it helps code clarity.

Cyan4973
Cyan4973 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor
@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @embg

@embg
Copy link
Contributor
embg commented May 29, 2024

@Federico-Maresca well done!

@embg embg merged commit 5e9a6c2 into facebook:dev May 29, 2024
94 checks passed
@embg embg mentioned this pull request May 29, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

5951 @Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Federico-Maresca @facebook-github-bot @Cyan4973 @embg
0