8000 fix missing include folder for resource compiler by b7f7 · Pull Request #4019 · facebook/zstd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix missing include folder for resource compiler #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix missing include folder for resource compiler #4019

merged 1 commit into from
Apr 16, 2024

Conversation

b7f7
Copy link
Contributor
@b7f7 b7f7 commented Apr 5, 2024

the cmake build with VS studio 2022 on windows does fail to build because rc does not have the include directory set.
include is now set for rc and build works

@facebook-github-bot
8000
Copy link

Hi @b7f7!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Cyan4973
Cyan4973 approved these changes Apr 6, 2024
View reviewed changes
Copy link
Contributor
@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cyan4973 Cyan4973 self-assigned this Apr 6, 2024
@dg0yt dg0yt mentioned this pull request Apr 10, 2024
Closed
@haampie haampie mentioned this pull request Apr 16, 2024
Closed
@Cyan4973 Cyan4973 merged commit da797d0 into facebook:dev Apr 16, 2024
This was referenced Jul 8, 2024
Open
Open
ELundby45 added a commit to AnacondaRecipes/zstd-feedstock that referenced this pull request Oct 8, 2024
@ELundby45
Add upstream patch.
0663296 
facebook/zstd#4019
@ELundby45 ELundby45 mentioned this pull request Oct 8, 2024
Merged
@luau-project luau-project mentioned this pull request Jan 26, 2025
Closed
@BrewTestBot BrewTestBot mentioned this pull request Feb 19, 2025
Merged
@AaronBeier AaronBeier mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees

@Cyan4973 Cyan4973

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@b7f7 @facebook-github-bot @Cyan4973
0