-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Unclear license status #3717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
so the oddballs are: |
Okay, so it seems that in core files, such as https://github.com/facebook/zstd/blob/d857369028d997c92ff1f1861a4d7f679a125464/lib/compress/zstd_compress_superblock.c , license specified properly. So, I'm exaggerated issue, I'm sorry about this. Still, please, properly specify the license in README |
Zstd is dual licensed under BSD or GPLv2, and we test that all files that are part of the library or CLI (under But you're right, we should fix the wording in our README to be more clear, and match the licensing in our headers, which is correct. |
We are licensed under BSD or GPLv2. It is clear in our headers, but not in the README. Fixes facebook#3717
We are licensed under BSD or GPLv2. It is clear in our headers, but not in the README. Fixes #3717
We are licensed under BSD or GPLv2. It is clear in our headers, but not in the README. Fixes facebook#3717
We are licensed under BSD or GPLv2. It is clear in our headers, but not in the README. Fixes facebook#3717
I'm piggybacking this question here since I think those that already commented might have some insight into this: Can anybody explain why the zstd sources are even dual-licensed BSD and GPL? BSD-3-Clause is already compatible with GPL, so I fail to see the point of this dual licensing. (It's not that it hurts functionally, it's just confusing.) |
@bilbothebaggins Initially Zstd was licensed under BSD + PATENTS clause, which was not compatible with GPL. Zstd was then dual licensed under GPL in order to be merged into the Linux kernel. Later, the PATENTS clause was removed from the BSD license. |
We are licensed under BSD or GPLv2. It is clear in our headers, but not in the README. Fixes facebook#3717
README states: "Zstandard is dual-licensed under BSD and GPLv2". Unfortunately such sentence is very unclear.
It doesn't tell whether these licenses are connected with "and" or "or".
In case you never heard that such distinction may be important here is link with explanation: https://spdx.github.io/spdx-spec/v2.3/SPDX-license-expressions/ , see section "D.4 Composite license expressions".
Please note, that this distinction is extraordinary important. Such decision should not be taken lightly. "Or" means that user of zstd may choose license. "And" means that user must abide to both. Choosing "or" means that zstd is "effectively BSD", i. e. that it is distributed by permissive license. But choosing "and" makes zstd "effectively GPL", i. e. copyleft.
You may say: "but README literally says "and" ". Well, yes, naive direct reading of README may suggest that "and" is intended. But I don't think this is what you really meant. Again: choosing "and" will turn zstd into copyleft software and thus its use in proprietary products will be disallowed.
So, please choose one of these two options, fix README and widely announce result. Users should be aware of such change in any case. Again: this is very important
The text was updated successfully, but these errors were encountered: