8000 [sl] alerts: make it compatible with Python3.8 by zzl0 · Pull Request #838 · facebook/sapling · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[sl] alerts: make it compatible with Python3.8 #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[sl] alerts: make it compatible with Python3.8 #838

wants to merge 1 commit into from

Conversation

zzl0
Copy link
Contributor
@zzl0 zzl0 commented Feb 19, 2024 •
edited
Loading

Summary:

re.Pattern[str] is not valid in Python 3.8

Test Plan:

Python 3.8.17 (default, Jul  9 2023, 20:57:35)
[Clang 14.0.3 (clang-1403.0.22.14.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import re
>>> from typing import Optional
>>> show_after_crashes_regex: Optional[re.Pattern[str]] = None
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'type' object is not subscriptable
>>> show_after_crashes_regex: Optional[re.Pattern] = None
>>>

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3e81997.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet < 42D2 /form>
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzl0 @facebook-github-bot
0