fix: export additional types to enable TypeScript declaration builds #1095
Conversation
|
Hi @pawelblaszczyk5! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
What changed / motivation ?
It was discussed a bit here: #1070
For generating declarations by TypeScript all types that would be needed by the output needs to be exported so it can properly reference them in
d.tsfile. It's really important to works correctly for e.g. in monorepo scenarios where part of your code can live in a separate package.These two types are used by the output of
styles.createcalls - you can observe this by hovering styles created with this function call. Example:(this is slightly modified fragment of code inside of repository
examples/example-nextjs/typetests/theming)Hence TypeScript couldn't generate the same type as in hover in
d.tsfile - because these types aren't exported from the latest release.Before changes (NOTE: I had to enable
declarationin tsconfig of this example to observe this error):After changes:
(no error 😃)
Linked PR/Issues
Fixes #1070
Additional Context
In theory I see that there's a
example-nextjswith directory namedtypesetsbut I see them being already broken (importing from the removedlib/StyleXTypesentry point. And not being verified anywhere. If you'd like me to create examples for cases which this change fixes inside of repo just let me know where I can place them. Thanks a lot in advance!Pre-flight checklist
Contribution Guidelines