8000 [eslint-plugin] add autofix for remaining nonstandard properties by mellyeliu · Pull Request #1093 · facebook/stylex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[eslint-plugin] add autofix for remaining nonstandard properties #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[eslint-plugin] add autofix for remaining nonstandard properties #1093

wants to merge 1 commit into from

Conversation

mellyeliu
8000
Copy link
Member

Adds autofix for remaning nonstandard properties (borderRadius, start/end) and nonstandard style values (for float and clear)

We will need to test sync this to see volume of lint errors, then see if @vincentriemer's CodemodService can run on this without needing to land the sync itself

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 6, 2025 •
edited
Loading

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.

benchmarks@0.13.1 compare
node ./compare.js /tmp/tmp.CealVRgkmW /tmp/tmp.W9T4XgHItN

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 507 506 1.00 -
· complex create 179 178 0.99 -
babel-plugin: stylex.createTheme
· basic themes 425 419 0.99 -
· complex themes 40 41 1.02 +

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 6, 2025 •
edited
Loading

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

benchmarks@0.13.1 compare
node ./compare.js /tmp/tmp.ACwOAi4lBz /tmp/tmp.ea481BaahY

Results Base Patch Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed 1,222 1,222 1.00
· minified 3,679 3,679 1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed 1,227 1,227 1.00
· minified 3,224 3,224 1.00
benchmarks/size/.build/bundle.js
· compressed 537,611 537,611 1.00
· minified 7,435,904 7,435,904 1.00
benchmarks/size/.build/stylex.css
· compressed 100,509 100,509 1.00
· minified 754,513 754,513 1.00

@mellyeliu mellyeliu force-pushed the valid-styles-nonstandard branch from 72e79e1 to 316d4fa Compare June 6, 2025 10:57
@mellyeliu mellyeliu mentioned this pull request Jun 6, 2025
Merged
@mellyeliu mellyeliu marked this pull request as ready for review June 6, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas necolas approved these changes

@Jta26 Jta26 Awaiting requested review from Jta26 Jta26 is a code owner

@vincentriemer vincentriemer Awaiting requested review from vincentriemer vincentriemer is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mellyeliu @necolas @facebook-github-bot
0