Publish/support format_version=7, related enhancements #13713
Closed
+238
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: * Make new format_version=7 a supported setting. * Small change to handling of disabled compression in fv=7: use empty compression manager compatibility name. * Get rid of GetDefaultBuiltinCompressionManager() in public API because it could cause unexpected+unsafe schema change on a user's CompressionManager if built upon the default built-in manager and we add a new built-in schema. Now must be referenced by explicit compression schema version in the public API. (That notion was already exposed in compressed secondary cache API, for better or worse.) * Improve some error messages for compression misconfiguration * Improve testing with ObjectLibrary and CompressionManagers * Improve testing of compression_name table property in BlockBasedTableTest.BlockBasedTableProperties2 * Improve some comments Test Plan: existing and updated tests
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
reviewed
Jun 20, 2025
| @@ -2365,10 +2368,49 @@ TEST_F(DBTest2, CompressionManagerCustomCompression) { | |||
| ASSERT_EQ(Get("d").size(), kValueSize); | |||
| ASSERT_EQ(Get("e").size(), kValueSize); | |||
|
|
|||
| // TODO: mix of compatibility names in same DB | |||
| // Add a file using mgr_bar | |||
There was a problem hiding this comment.
Related to your previous PR - "...// Verify it was compressed with snappy" in line 2326 above should be with LZ4
hx235
approved these changes
Jun 20, 2025
|
@pdillinger has updated the pull request. You must reimport the pull request before landing. |
|
@pdillinger has updated the pull request. You must reimport the pull request before landing. |
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mszeszko-meta
approved these changes
Jun 20, 2025
|
@pdillinger merged this pull request in 78c83ac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: existing and updated tests. Notably, the crash test has already been running with (unpublished) format_version=7