Add variable size prefix for key generator class + improve documentation #13709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KareemOtoum
commented
Jun 21, 2025
| bool is_sequential_ = false; | ||
| uint32_t next_sequential_key_ = 0; | ||
| char buff_[256] = {0}; | ||
| const int MULTIPLIER = 3; | ||
|
|
||
| void static Encode(char* buf, uint32_t value) { | ||
| // helper function to encode variable size prefix or key numbers | ||
| void static Encode(char* buf, uint32_t value, uint32_t size) { |
There was a problem hiding this comment.
Please note that as of now, the encode function can only encode up to 4 bytes for the prefix/key, I am planning on changing this with my next pr where I will look at extending the max number of keys that can be generated.
|
@yiwu-arbug would you be able to look at this pr when you have time? cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds an unfinished feature in the
KeyGeneratorclass atmicrobench/db_basic_bench.cc, removing the hard-coded limit for the prefix size of the key generator and improves the documentation of the class.Previously, the key generator would accept an optional prefix and force a size of 4 bytes if one was provided. The changes in this pr make it so that the constructor accepts a
size_t prefix_size = 4as a parameter to represent the desired bytes for the keys prefix. An assert ensures that the size can represent the givensize_t prefix_num.To support this new feature's addition, the
Encodefunction was also changed to accept a size parameter for encoding a variable size key/prefix while preserving endianness (it is limited to 4 bytes but will be addressed in future pr's where I plan to address themax_keys_limit aswell).This change improves flexibility for key generation in benchmarks and tests.
As a next step, I plan to explore increasing the maximum number of keys (max_keys_) that can be generated, which is currently limited by an assert. Feedback on this approach or suggestions for future improvements are welcome!