Fix crossbuild jar packaging #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) There is no need to download and install the compression libraries twice just to get access to their header files during the compile phase. 2) Ensure that the compression library headers files used during the compile phase are the same ones used to build the static library that is linked into the library.
…es to be output to the java/target directory. The uber crossbuild jar is then assembled within the java/target directory.
|
Thanks for fixing this. |
yhchiang
added a commit
that referenced
this pull request
Oct 13, 2015
Fix crossbuild jar packaging Conflicts: Makefile java/crossbuild/build-linux-centos.sh
yhchiang
added a commit
that referenced
this pull request
Oct 15, 2015
Fix crossbuild jar packaging Conflicts: Makefile java/crossbuild/build-linux-centos.sh
yhchiang
added a commit
that referenced
this pull request
Dec 27, 2015
Fix crossbuild jar packaging Conflicts: Makefile java/crossbuild/build-linux-centos.sh Conflicts: Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the java crossbuild jar packaging. Prior to this change the following error would occur as a result of running
make jclean clean rocksdbjavastaticreleaseafter a clean clone/checkout.This is addressed by forcing all java artifacts (jars and libraries) to write out to the java/target directory, and then the packaging of the final jar is done within that directory. This has the added benefit of
make jcleanactually working to clean up all of the java output files.