[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: Construct RawValue directly from jsi::Value #48047

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

wip: Construct RawValue directly from jsi::Value #48047

wants to merge 25 commits into from
+569 −126

Conversation

hannojg
Copy link
Contributor
@hannojg hannojg commented Dec 2, 2024 •
edited
Loading

Summary:

Still WIP, will update once all settled

TODO:

  • Go through tester app, see if everything works
  • Check if it works on android
  • Provide cast function in RawValue to access jsi::Value directly
  • Cleanup PR / review
  • Example use case to access jsi::Value directly (can we use fromRawValue to convert the JSI prop ourselves?)

Changelog:

Test Plan:

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2024
@react-native-bot
Copy link
Collaborator
react-native-bot commented Dec 2, 2024 •
edited
Loading
Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against 7a2aaf2

mrousavy
mrousavy reviewed Dec 3, 2024
View reviewed changes
packages/react-native/ReactCommon/react/renderer/core/RawValue.h Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/core/RawValue.h Outdated Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/core/RawValue.h Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/core/RawValue.h Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/core/RawValue.h Outdated Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/core/RawValue.h Outdated Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/core/RawValue.h Outdated Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/core/RawValue.h Outdated Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/core/RawValue.h Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/core/RawValue.h Outdated Show resolved Hide resolved
hannojg and others added 15 commits December 3, 2024 14:20
@hannojg @mrousavy
Update packages/react-native/ReactCommon/react/renderer/core/RawValue.h
032674a 
Co-authored-by: Marc Rousavy <marcrousavy@hotmail.com>
@hannojg @mrousavy
Update packages/react-native/ReactCommon/react/renderer/core/RawValue.h
627ce7f 
Co-authored-by: Marc Rousavy <marcrousavy@hotmail.com>
@hannojg @mrousavy
Update packages/react-native/ReactCommon/react/renderer/core/RawValue.h
0b4d071 
Co-authored-by: Marc Rousavy <marcrousavy@hotmail.com>
@hannojg
rename JsiPair -> JsiValuePair
aa3519a
@hannojg
add API to access raw JSI value
79507ed
@hannojg
fix cast to JsiValuePair method
c6e84cb
@hannojg
perf: use emplace + move
490f85e
@hannojg
explicit types
72b7265
@hannojg
cleanup: use as and get jsi values correctly
a05fa9d
@hannojg
use explicit types
f078147
@hannojg
change asX calls to getX as we asserted earlier
3dc5736
@hannojg
remove noexcept as std::get and isNull() can throw
a2fa883
@hannojg
remove untrue doc comment
f7ea9a3
@hannojg
make runtime first arg, jsiValue second
5c7f09d
@hannojg
fix release build add empty return value
7a2aaf2
hannojg added a commit to hannojg/nitro that referenced this pull request Dec 3, 2024
@hannojg
patch react native to allow for JSI in RawValue
598d9d1 
Includes changes from: facebook/react-native#48047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrousavy mrousavy mrousavy left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannojg @react-native-bot @mrousavy @facebook-github-bot