[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default implementation for Object.getPrototypeOf and Object.setPrototypeOf #47996

Closed
wants to merge 1 commit into from

Conversation

tsaichien
Copy link
Contributor

Summary:
Getting and setting an Object's prototype is convulted. Users have to
call into the global object to get the method, then call it.

This diff adds a JSI API for Object.getPrototype and Object.setPrototype
to make it easy for users.

Differential Revision: D66562549

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 28, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66562549

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66562549

tsaichien added a commit to tsaichien/react-native that referenced this pull request Nov 28, 2024
…ject.setPrototypeOf (facebook#47996)

Summary:

Getting and setting an Object's prototype is convulted. Users have to
call into the global object to get the method, then call it.

This diff adds a JSI API for Object.getPrototype and Object.setPrototype
to make it easy for users.

Changelog: [Internal]

Differential Revision: D66562549
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66562549

tsaichien added a commit to tsaichien/react-native that referenced this pull request Dec 4, 2024
…ototypeOf (facebook#47996)

Summary:

Getting and setting an Object's prototype is convulted. Users have to
call into the global object to get the method, then call it.

This diff adds a JSI API for Object.getPrototype and Object.setPrototype
to make it easy for users.

Changelog: [Internal]

Differential Revision: D66562549
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66562549

tsaichien added a commit to tsaichien/react-native that referenced this pull request Dec 5, 2024
…ototypeOf (facebook#47996)

Summary:

Getting and setting an Object's prototype is convoluted. Users have to
call into the global object to get the method, then call it.

This diff adds a JSI API for Object.getPrototype and Object.setPrototype
to make it easy for users.

Changelog: [Internal]

Differential Revision: D66562549
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66562549

tsaichien added a commit to tsaichien/react-native that referenced this pull request Dec 6, 2024
…ototypeOf (facebook#47996)

Summary:

Getting and setting an Object's prototype is convoluted. Users have to
call into the global object to get the method, then call it.

This diff adds a JSI API for Object.getPrototype and Object.setPrototype
to make it easy for users.

Changelog: [Internal]

Differential Revision: D66562549
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66562549

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66562549

tsaichien added a commit to tsaichien/react-native that referenced this pull request Dec 12, 2024
…ject.setPrototypeOf (facebook#47996)

Summary:

Getting and setting an Object's prototype is convoluted. Users have to
call into the global object to get the method, then call it.

This diff adds a JSI API for Object.getPrototype and Object.setPrototype
to make it easy for users.

Changelog: [Internal]

Reviewed By: fbmal7

Differential Revision: D66562549
…ototypeOf (facebook#47996)

Summary:

Getting and setting an Object's prototype is convoluted. Users have to
call into the global object to get the method, then call it.

This diff adds a JSI API for Object.getPrototype and Object.setPrototype
to make it easy for users.

Changelog: [Internal]

Reviewed By: fbmal7

Differential Revision: D66562549
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66562549

facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Dec 12, 2024
…ototypeOf

Summary:
X-link: facebook/react-native#47996

Getting and setting an Object's prototype is convoluted. Users have to
call into the global object to get the method, then call it.

This diff adds a JSI API for Object.getPrototype and Object.setPrototype
to make it easy for users.

Changelog: [Internal]

Reviewed By: fbmal7

Differential Revision: D66562549

fbshipit-source-id: 85a2e49deb9d00500544de4cc5ab123c4717398e
facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Dec 12, 2024
…ototypeOf

Summary:
X-link: facebook/react-native#47996

Getting and setting an Object's prototype is convoluted. Users have to
call into the global object to get the method, then call it.

This diff adds a JSI API for Object.getPrototype and Object.setPrototype
to make it easy for users.

Changelog: [Internal]

Reviewed By: fbmal7

Differential Revision: D66562549

fbshipit-source-id: 85a2e49deb9d00500544de4cc5ab123c4717398e
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 04f33ec.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 12, 2024
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @tsaichien in 04f33ec

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants