8000 docs remove rootNode for componentDidMount/Update by chenglou · Pull Request #582 · facebook/react · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs remove rootNode for componentDidMount/Update #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs remove rootNode for componentDidMount/Update #582

wants to merge 1 commit into from
+5 −11

Conversation

chenglou
Copy link
Contributor

No description provided.

@vjeux
Copy link
Contributor
vjeux commented Nov 21, 2013

cc @zpao. I'm good with this change but you wanted to mark it as deprecated and really remove it later.

@chenglou
Copy link
Contributor Author

where would be a good place to mark this?

zpao
zpao reviewed Nov 27, 2013
View reviewed changes
docs/docs/ref-03-component-specs.md
```

Invoked immediately after rendering occurs. At this point in the lifecycle, the component has a DOM representation which you can access via the `rootNode` argument or by calling `this.getDOMNode()`.
Invoked immediately after rendering occurs. At this point in the lifecycle, the component has a DOM representation which you can access via `this.getDOMNode()`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a > Note about the previous API here. Since we aren't providing and deprecation notices we should mention it somewhere. Something like we did for http://facebook.github.io/react/docs/top-level-api.html#react.unmountcomponentatnode

@chenglou chenglou closed this Nov 27, 2013
@chenglou chenglou deleted the didMout-didUpdate-new branch November 28, 2013 02:51
@penx penx mentioned this pull request Jan 25, 2021
Closed
@sreegodavarthi sreegodavarthi mentioned this pull request Jan 25, 2021
Open
@joseroubert08 joseroubert08 mentioned this pull request Jan 25, 2021
Open
This was referenced Sep 5, 2021
Open
Open
Open
This was referenced Jan 12, 2022
Open
Open
Open
This was referenced Feb 9, 2022
Open
Open
Open
@joseroubert08 joseroubert08 mentioned this pull request Jan 2, 2024
Open
@sreegodavarthi sreegodavarthi mentioned this pull request Jan 2, 2024
Open
@sreegodavarthi sreegodavarthi mentioned this pull request Mar 15, 2024
Open
@joseroubert08 joseroubert08 mentioned this pull request Mar 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenglou @vjeux @zpao
0