8000 Clean up enableSiblingPrerendering flag by jackpope · Pull Request #32319 · facebook/react · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clean up enableSiblingPrerendering flag #32319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Clean up enableSiblingPrerendering flag #32319

merged 1 commit into from
May 9, 2025
+866 −1,178

Conversation

jackpope
Copy link
Contributor
@jackpope jackpope commented Feb 6, 2025

No description provided.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 6, 2025
@react-sizebot
Copy link
react-sizebot commented Feb 6, 2025 •
edited
Loading

Comparing: ac06829...6fa9e95

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 528.26 kB 528.26 kB = 93.16 kB 93.16 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 646.11 kB 646.11 kB = 113.67 kB 113.67 kB
facebook-www/ReactDOM-prod.classic.js = 674.81 kB 673.95 kB = 118.51 kB 118.39 kB
facebook-www/ReactDOM-prod.modern.js = 665.09 kB 664.23 kB = 116.91 kB 116.78 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactART-dev.classic.js = 729.78 kB 728.07 kB = 113.35 kB 113.10 kB
facebook-www/ReactART-dev.modern.js = 720.28 kB 718.57 kB = 111.61 kB 111.36 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js < 8000 strong>= 679.46 kB 677.78 kB = 110.13 kB 109.90 kB
react-native/implementations/ReactFabric-dev.fb.js = 676.06 kB 674.39 kB = 109.70 kB 109.46 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 415.88 kB 414.38 kB = 71.00 kB 70.76 kB
react-native/implementations/ReactFabric-profiling.fb.js = 414.29 kB 412.79 kB = 70.78 kB 70.56 kB
facebook-www/ReactART-prod.classic.js = 388.62 kB 387.15 kB = 64.98 kB 64.78 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 387.71 kB 386.23 kB = 66.84 kB 66.61 kB
react-native/implementations/ReactFabric-prod.fb.js = 386.07 kB 384.59 kB = 66.69 kB 66.45 kB
facebook-www/ReactART-prod.modern.js = 378.64 kB 377.16 kB = 63.31 kB 63.13 kB

Generated by 🚫 dangerJS against 6fa9e95

@jackpope jackpope force-pushed the enable-sibling-prerendering-cleanup branch from 429a8ec to e83bf3f Compare February 6, 2025 21:19
@jackpope jackpope force-pushed the enable-sibling-prerendering-cleanup branch from bda4cb1 to 2fbfc41 Compare February 7, 2025 15:01
@jackpope jackpope force-pushed the enable-sibling-prerendering-cleanup branch from 2fbfc41 to e0e1662 Compare February 7, 2025 15:08
@jackpope jackpope force-pushed the enable-sibling-prerendering-cleanup branch from e0e1662 to a338298 Compare April 30, 2025 18:57
@jackpope jackpope requested a review from rickhanlonii April 30, 2025 19:10
rickhanlonii
rickhanlonii approved these changes May 8, 2025
View reviewed changes
Copy link
Member
@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yah

@jackpope jackpope force-pushed the enable-sibling-prerendering-cleanup branch from 5337f80 to 6fa9e95 Compare May 8, 2025 22:47
@jackpope jackpope merged commit 4ca97e4 into facebook:main May 9, 2025
239 checks passed
@jackpope jackpope deleted the enable-sibling-prerendering-cleanup branch May 9, 2025 00:49
github-actions bot pushed a commit that referenced this pull request May 9, 2025
@jackpope
Clean up enableSiblingPrerendering flag (#32319)
a26db9b 
DiffTrain build for [4ca97e4](4ca97e4)
github-actions bot pushed a commit that referenced this pull request May 9, 2025
@jackpope
Clean up enableSiblingPrerendering flag (#32319)
a5a6ecd 
DiffTrain build for [4ca97e4](4ca97e4)
@vercel-release-bot vercel-release-bot mentioned this pull request May 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackpope @react-sizebot @rickhanlonii @facebook-github-bot
0