fix(eslint-plugin-react-hooks): accepting `as` expressions as deps array #28189

StyleShit · 2024-02-01T18:10:04Z

Summary

This PR closes #25844
The original issue talks about as const, but seems like it fails for any as X expressions since it adds another nesting level to the AST.

EDIT: Also closes #20162

How did you test this change?

Added unit tests

Closes facebook#25844

facebook-github-bot · 2024-02-01T18:10:10Z

Hi @StyleShit!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

react-sizebot · 2024-02-01T18:15:10Z

Comparing: 53b12e4...aa068d1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	591.32 kB	591.32 kB	=	104.34 kB	104.34 kB
facebook-www/ReactDOM-prod.modern.js	=	575.08 kB	575.08 kB	=	101.43 kB	101.43 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js	+0.37%	92.14 kB	92.49 kB	+0.35%	21.70 kB	21.77 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js	+0.37%	92.14 kB	92.49 kB	+0.35%	21.70 kB	21.77 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js	+0.37%	92.29 kB	92.63 kB	+0.35%	21.72 kB	21.80 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.36%	93.13 kB	93.46 kB	+0.24%	21.92 kB	21.97 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.36%	93.13 kB	93.46 kB	+0.24%	21.92 kB	21.97 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.36%	93.27 kB	93.61 kB	+0.24%	21.94 kB	21.99 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.min.js	+0.33%	27.00 kB	27.08 kB	+0.21%	9.30 kB	9.32 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.min.js	+0.33%	27.00 kB	27.08 kB	+0.21%	9.30 kB	9.32 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.min.js	+0.32%	27.59 kB	27.68 kB	+0.30%	9.47 kB	9.50 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Generated by 🚫 dangerJS against aa068d1

eps1lon

Makes sense, thank you. Can you sign the CLA so that we can merge this? It may take a while between signing and the status to become green.

StyleShit · 2024-02-01T18:26:46Z

Already signed when opening the PR, just waiting for it to update 😄

facebook-github-bot · 2024-02-01T19:23:05Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

…ray (#28189) ## Summary This PR closes #25844 The original issue talks about `as const`, but seems like it fails for any `as X` expressions since it adds another nesting level to the AST. EDIT: Also closes #20162 ## How did you test this change? Added unit tests DiffTrain build for [a1433ca](a1433ca)

…ray (#28189) ## Summary This PR closes #25844 The original issue talks about `as const`, but seems like it fails for any `as X` expressions since it adds another nesting level to the AST. EDIT: Also closes #20162 ## How did you test this change? Added unit tests

…ray (facebook#28189) ## Summary This PR closes facebook#25844 The original issue talks about `as const`, but seems like it fails for any `as X` expressions since it adds another nesting level to the AST. EDIT: Also closes facebook#20162 ## How did you test this change? Added unit tests

…ray (#28189) ## Summary This PR closes #25844 The original issue talks about `as const`, but seems like it fails for any `as X` expressions since it adds another nesting level to the AST. EDIT: Also closes #20162 ## How did you test this change? Added unit tests DiffTrain build for commit a1433ca.

@kassens

##### [v5.0.0](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#500) - **New Violations:** Component names now need to start with an uppercase letter instead of a non-lowercase letter. This means `_Button` or `_component` are no longer valid. ([@kassens](https://github.com/kassens)) in [#25162](facebook/react#25162)  - Consider dispatch from `useActionState` stable. ([@eps1lon](https://github.com/eps1lon) in [#29665](facebook/react#29665)) - Add support for ESLint v9. ([@eps1lon](https://github.com/eps1lon) in [#28773](facebook/react#28773)) - Accept `as` expression in callback. ([@StyleShit](https://github.com/StyleShit) in [#28202](facebook/react#28202)) - Accept `as` expressions in deps array. ([@StyleShit](https://github.com/StyleShit) in [#28189](facebook/react#28189)) - Treat `React.use()` the same as `use()`. ([@kassens](https://github.com/kassens) in [#27769](facebook/react#27769)) - Move `use()` lint to non-experimental. ([@kassens](https://github.com/kassens) in [#27768](facebook/react#27768)) - Support Flow `as` expressions. ([@cpojer](https://github.com/cpojer) in [#27590](facebook/react#27590)) - Allow `useEffect(fn, undefined)`. ([@kassens](https://github.com/kassens) in [#27525](facebook/react#27525)) - Disallow hooks in async functions. ([@acdlite](https://github.com/acdlite) in [#27045](facebook/react#27045)) - Rename experimental `useEvent` to `useEffectEvent`. ([@sebmarkbage](https://github.com/sebmarkbage) in [#25881](facebook/react#25881)) - Lint for presence of `useEvent` functions in dependency lists. ([@poteto](https://github.com/poteto) in [#25512](facebook/react#25512)) - Check `useEvent` references instead. ([@poteto](https://github.com/poteto) in [#25319](facebook/react#25319)) - Update `RulesOfHooks` with `useEvent` rules. ([@poteto](https://github.com/poteto) in [#25285](facebook/react#25285))

fix(eslint-plugin-react-hooks): accepting as expressions as deps array

6129f47

Closes facebook#25844

eps1lon approved these changes Feb 1, 2024

View reviewed changes

Merge branch 'main' into fix/exhaustive-deps-ts-as

aa068d1

facebook-github-bot added the CLA Signed label Feb 1, 2024

eps1lon merged commit a1433ca into facebook:main Feb 1, 2024
36 checks passed

gnoff mentioned this pull request Feb 5, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin-react-hooks): accepting `as` expressions as deps array #28189

fix(eslint-plugin-react-hooks): accepting `as` expressions as deps array #28189

fix(eslint-plugin-react-hooks): accepting as expressions as deps array #28189

fix(eslint-plugin-react-hooks): accepting as expressions as deps array #28189

Conversation

Summary

How did you test this change?

Action Required

Process

Critical size changes

Significant size changes

Choose a reason for hiding this comment

fix(eslint-plugin-react-hooks): accepting `as` expressions as deps array #28189

fix(eslint-plugin-react-hooks): accepting `as` expressions as deps array #28189