Guard against legacy context not being supported in DevTools fixture #28596

eps1lon · 2024-03-20T16:12:21Z

Legacy context was removed from experimental builds so the default setup would hide important fixtures.

Now it just assumes that any crash within the tree rendering legacy context is due to legacy context not being supported.

I didn't remove the components entirely since this fixture can be used with older versions of React where we would want to check if legacy context still works.

Legacy context was removed from experimental builds so the default setup would hide important fixtures. Now it just assumes that any crash within the tree rendering legacy context is due to legacy context not being supported. I didn't remove since this fixture can be used with older versions of React where we would want to check if legacy context still works.

hoxyq

Thanks!

…acebook#28596)

Full list of changes: * Look for a ReactMemoCacheSentinel on state ([gsathya](https://github.com/gsathya) in [#28831](#28831)) * Use use() in the Cache if available ([sebmarkbage](https://github.com/sebmarkbage) in [#28793](#28793)) * feat[devtools-fusebox]: support theme option ([hoxyq](https://github.com/hoxyq) in [#28832](#28832)) * feat[devtools]: add package for fusebox integration ([hoxyq](https://github.com/hoxyq) in [#28553](#28553)) * feat[devtools]: add method for connecting backend with custom messaging protocol ([hoxyq](https://github.com/hoxyq) in [#28552](#28552)) * Rename SECRET INTERNALS to `__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE` ([sebmarkbage](https://github.com/sebmarkbage) in [#28789](#28789)) * Flatten ReactSharedInternals ([sebmarkbage](https://github.com/sebmarkbage) in [#28783](#28783)) * feat[devtools]: ship source maps for content scripts and ignore list installHook script ([hoxyq](https://github.com/hoxyq) in [#28730](#28730)) * Track Owner for Server Components in DEV ([sebmarkbage](https://github.com/sebmarkbage) in [#28753](#28753)) * Move ReactDOMLegacy implementation into RootFB ([sebmarkbage](https://github.com/sebmarkbage) in [#28656](#28656)) * Reland #28672: Remove IndeterminateComponent ([gnoff](https://github.com/gnoff) in [#28681](#28681)) * Remove reference to deleted <Cache> in un-linted file ([josephsavona](https://github.com/josephsavona) in [#28715](#28715)) * [be] Remove unshipped experimental <Cache> element type ([josephsavona](https://github.com/josephsavona) in [#28698](#28698)) * Revert "Remove module pattern function component support" ([rickhanlonii](https://github.com/rickhanlonii) in [#28670](#28670)) * Remove module pattern function component support ([gnoff](https://github.com/gnoff) in [#27742](#27742)) * [RTR] Enable warning flag ([jackpope](https://github.com/jackpope) in [#28419](#28419)) * Update error messages ([rickhanlonii](https://github.com/rickhanlonii) in [#28652](#28652)) * fix[devtools/ci]: split profiling cache test for different react versions and toEqual checker ([hoxyq](https://github.com/hoxyq) in [#28628](#28628)) * Guard against legacy context not being supported in DevTools fixture ([eps1lon](https://github.com/eps1lon) in [#28596](#28596)) * Use `declare const` instead of `declare var` ([kassens](https://github.com/kassens) in [#28599](#28599)) * Update isConcurrent RTR option usage ([jackpope](https://github.com/jackpope) in [#28546](#28546)) * Disable legacy context ([kassens](https://github.com/kassens) in [#27991](#27991)) * Remove invokeGuardedCallback and replay trick ([sebmarkbage](https://github.com/sebmarkbage) in [#28515](#28515)) * Remove remaining usages of ReactTestUtils in tests unrelated to `react-dom/test-util` ([eps1lon](https://github.com/eps1lon) in [#28534](#28534)) * fix[devtools/e2e]: fixed source inspection in e2e tests ([hoxyq](https://github.com/hoxyq) in [#28518](#28518)) * Devtools: Display actual pending state when inspecting `useTransition` ([eps1lon](https://github.com/eps1lon) in [#28499](#28499))

eps1lon requested a review from hoxyq March 20, 2024 16:12

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 20, 2024

eps1lon force-pushed the devtools/fixture-legacy-context branch from f7831fe to 061be1c Compare March 20, 2024 16:17

eps1lon changed the title ~~Guard against legacy context being not supported in DevTools fixture~~ Guard against legacy context not being supported in DevTools fixture Mar 20, 2024

This was referenced Mar 20, 2024

DevTools: Rely on sourcemaps to compute hook name of built-in hooks in newer versions #28593

Merged

Devtools: Add support for useFormStatus #28413

Merged

hoxyq approved these changes Mar 25, 2024

View reviewed changes

eps1lon merged commit e373190 into facebook:main Mar 25, 2024
38 checks passed

eps1lon deleted the devtools/fixture-legacy-context branch March 25, 2024 13:30

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Guard against legacy context not being supported in DevTools fixture (f…

7b1615e

…acebook#28596)

hoxyq mentioned this pull request Apr 15, 2024

React DevTools 5.0.2 -> 5.1.0 #28840

Merged

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Guard against legacy context not being supported in DevTools fixture #28596

Guard against legacy context not being supported in DevTools fixture #28596

Guard against legacy context not being supported in DevTools fixture #28596

Guard against legacy context not being supported in DevTools fixture #28596

Conversation

Choose a reason for hiding this comment