ignore checking client entry point for UMD build #24274
Conversation
|
Hi @alireza-molaee! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Oh wait, we have this constant? I totally forgot! |
|
I submit CLA form. Do I have to do anything else to continue? |
|
No, let's give it a bit of time! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Comparing: 9ededef...39e3a81 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
thank you! |
Summary
it solve (React DOM UMD always warns in React 18 #24221)
for UMD build it does not matter entry point, so we can ignore checking entry point.
How did you test this change?
build react-dom and check bundle file (react-dom.development.js)