10000 RC1: Unexpected detached subtree found (possible regression?) · Issue #4865 · facebook/react · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

RC1: Unexpected detached subtree found (possible regression?) #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
syranide opened this issue Sep 14, 2015 · 7 comments · Fixed by #4903
Closed

RC1: Unexpected detached subtree found (possible regression?) #4865

syranide opened this issue Sep 14, 2015 · 7 comments · Fixed by #4903
Assignees
@sophiebits
Milestone
0.14
8000

Comments

@syranide
Copy link
Contributor

Since upgrading from beta3 to rc1 I've seen this error a few times in production. Haven't been able to trace the source yet though.

cc @spicyj
@syranide
Copy link
Contributor Author

I was unmounting a root during a keyboard event which caused this to happen. I think this has always been a problem? Perhaps we've only been lucky... leaving open just to be sure.

EDIT: Could it make sense to have something along the lines of React.afterTransaction(callback)? Allowing you to schedule things to occur as soon as the current transaction ends.

@sophiebits
Copy link
Collaborator

This invariant was new in this release. We also hit one case at FB that I haven't yet investigated. Probably need to change something for the final release.

@sophiebits sophiebits added this to the 0.14 milestone Sep 14, 2015
@philholden
Copy link

I have seen this on RC1 can't find a sequence of actions to repeat it.

@iammerrick
Copy link
Contributor

I'm running into this issue as well when conditionally rendering based on state. Not sure how to boil it down to a simple reproducible bug report yet.

@iammerrick
Copy link
Contributor

My issue only happens when I am leveraging FastClick. Didn't happen before 0.14.

@iammerrick
Copy link
Contributor

I've found it is because the events are handled in a different order with fastclick, so the batching gets weird...

@iammerrick
Copy link
Contributor

e.g. click gets fired before touchEnd, so click handler setState to remove subtree, and then react tries to do something with it in touch end perhaps?

@sophiebits sophiebits mentioned this issue Sep 18, 2015
Merged
sophiebits added a commit to sophiebits/react that referenced this issue Sep 18, 2015
@sophiebits
Just ignore events on unmounted components
499073a 
Fixes facebook#4865.
sophiebits added a commit to sophiebits/react that referenced this issue Sep 18, 2015
@sophiebits
Just ignore events on unmounted components
1cf4720 
Fixes facebook#4865.
sophiebits added a commit to sophiebits/react that referenced this issue Sep 18, 2015
@sophiebits
Just ignore events on unmounted components
45f85a6 
Fixes facebook#4865 and also seems to fixes facebook#3790.
@sophiebits sophiebits mentioned this issue Jan 23, 2024
Merged
This was referenced May 9, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sophiebits sophiebits

Labels
None yet
Projects
None yet
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

Just ignore events on unmounted components sophiebits/react
4 participants
@sophiebits @iammerrick @philholden @syranide
0