Update hdays.py Turkey import path #2431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Yeah had to deploy with holidays<0.25 to fix breakages. |
|
cc: @tcuongd and @WardBrian |
|
A simple test (dynamically loading main classes and all country classes) would have caught that in this project's CI, my 2c |
|
Just one test failure (serialization) due to an issue with pandas 2.0 that we're aware of, described here: #2401 (comment) Merging this PR and doing a release. Edit: Ah I just realised the release won't go through unless we patch the test...looking into it now. |
tcuongd
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2430
This is a quick fix for the issue caused by python-holidays v0.25 release.