added -t flag to stop time and memory message from being shown in the… #358
Conversation
|
Hi @arnav-jain1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Signed |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hi, thanks for making a PR! I think the linked issue is asking, "could we make the entire last line optional, and have the output just be the list of errors". While the output is deterministic with your change, there are some use cases where the last line would still need to be filtered out. I think it would be cleaner to have some sort of |
|
Made the change |
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@yangdanny97 merged this pull request in 10ef9ba. |
|
Yippee |
Adds feature requested in #301. The flag is -t (or --no-timer) and just removes the part of the output that has memory usage and time taken. Simple enough.
To be honest I am not sure how to add it to the printed information when running --help. If shown how to, I can add it and update the commit.