Fix LSP's hanging threads, refactor connection #185
Conversation
|
Hi @mrsobakin! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our C 8000 ontributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@SamChou19815 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@SamChou19815 merged this pull request in 204c849. |
Fixes a deadlock where
wait_on_connection()would hang indefinitely because the sending side of theConnectionwasn’t properly closed. You can find the full context here.I’ve added an explicit drop of the
Serverto ensure the connection is properly shut down before waiting.I've also taken the liberty to clean up the LSP connection code a bit: clunky ad-hoc
sendclosure was replaced with aServerConnectionwrapper aroundArc<Connection>, which groups message sending logic into its methods.