test: Add tests documenting init helper method limitation #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds test cases for four reported issues: 1. Issue facebook#547: Dict narrowing after None checks - Already fixed in current version - Tests confirm proper type narrowing for Optional[Dict] after is not None checks - Tests cover attribute chains, early returns, and nested narrowing 2. Issue facebook#548: Pydantic Field overload resolution - Tests document expected behavior with positional arguments - Issue stems from Pydantic's use of sentinel values in type stubs - Workaround: use keyword arguments (default=value) 3. Issue facebook#549: False positives on union types with Any - Added type_contains_any() helper to check for Any in unions - When Any is present in a union, allow any attribute access without errors - Partial fix: works for explicit unions, Dict[str, Any] needs separate handling 4. Issue facebook#550: Init helper methods - Tests document the limitation that helper methods aren't recognized - Full fix requires flow analysis to track methods called from __init__ These tests improve code coverage and document both working features and known limitations, providing a foundation for future improvements.
These tests document that Pyrefly currently doesn't recognize helper methods called from __init__ as valid attribute-defining methods. A full fix would require flow analysis to track which methods are called during construction. Related to facebook#550
|
Related to #550 |
yangdanny97
requested changes
Jun 24, 2025
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds tests documenting the current limitation where helper methods called from
__init__are not recognized as valid attribute-defining methods.Issue #550: False Positive for Initialization Helper Methods
Pyrefly reports "implicitly-defined-attribute" errors when attributes are set in helper methods called from
__init__, which is a common pattern for organizing initialization logic.Current Behavior
Pyrefly only recognizes these methods as valid for attribute definition:
__init__,__init_subclass__,__new__setUp,setUpClass, and related methodsHelper methods called from these recognized methods are not tracked.
Tests Added
The test file
issue_550_init_helpers.rsincludes:Future Enhancement
A full fix would require flow analysis to:
__init__Related to #550 - This PR documents the current limitation to guide future implementation.