fix(bundler): fix docusaurus start using concatenateModules: true
#11222
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +310 B (0%) Total Size: 11.5 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +300 B (0%) Total Size: 11.9 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using
concatenateModules: !isServeron the base bundler config is not ideal because it will turn it on fordocusaurus starttoo, while we only want the optimization to be enabled for the build client config.Reminder: by default the flag is enabled in production mode.
Before:
docusaurus start: on (should be off)docusaurus build- client: ondocusaurus build- server: offdocusaurus build --dev- client: on (should be off)docusaurus build --dev- server: offAfter
docusaurus start: offdocusaurus build- client: ondocusaurus build- server: offdocusaurus build --dev- client: offdocusaurus build --dev- server: offReported by @felipecrs here:
#11199 (comment)
Also noticed by Rspack team:
Test Plan
We don't have good coverage for that 😅 hard to default default values of bundlers by observing their dev server behavior.
From my local tests, the impact is not very significant for our own website, but could be for larger sites?
Test links
https://deploy-preview-11222--docusaurus-2.netlify.app/