fix(core): fix docusaurus start error for macOS users with no Chromium-based browser
#11205
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +310 B (0%) Total Size: 11.5 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
7 tasks
|
Size Change: +300 B (0%) Total Size: 11.9 MB ℹ️ View Unchanged
|
7 tasks
7 tasks
AlbertVilaCalvo
added a commit
to AlbertVilaCalvo/Wiki
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #11204
grep returns exit code 1 by default when the no match found, leading to an error for macOS users that have no Chromium-based browser installed
Test Plan
Local only 😅
This reverts to what CRA used to do before my change: swallow errors
See also PR introducing the bug: #11007