8000 docs: add a warning when setting java or scala in additionalLanguages by takashi-uchida · Pull Request #11081 · facebook/docusaurus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: add a warning when setting java or scala in additionalLanguages #11081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: add a warning when setting java or scala in additionalLanguages #11081

wants to merge 1 commit into from

Conversation

takashi-uchida
Copy link

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @takashi-uchida!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@takashi-uchida takashi-uchida changed the title Update markdown-features-code-blocks.mdx docs: add a warning when setting java or scala in additionalLanguages Apr 9, 2025
@netlify Netlify
Copy link
netlify bot commented Apr 9, 2025

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 1dcea7a
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67f661be32ce510008899edb
😎 Deploy Preview https://deploy-preview-11081--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 9, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 39 🟢 98 🟢 100 🟢 100 Report
/docs/installation 🔴 47 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 70 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 57 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 46 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 61 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 71 🟢 100 🟢 100 🟠 86 Report

slorber
slorber requested changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator
@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's the right thing to do

Also, I can only merge PRs if the CLA is signed

website/docs/guides/markdown-features/markdown-features-code-blocks.mdx
Comment on lines +117 to +121
:::warning

When using Java or Scala, both must be included together in additionalLanguages

:::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true, but this doesn't only apply to Java/Scala, and other related languages are affected as well.

See also past issues

Do we really want to add a documentation like this for something that is non-exhaustive, and can eventually be handled with code automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber slorber requested changes

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takashi-uchida @facebook-github-bot @slorber
0