feat(theme): add theme layout stable CSS classes #10945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +39.1 kB (+0.35%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +38.8 kB (+0.34%) Total Size: 11.6 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding stable classes to main theme layout elements is helpful for users to write reliable CSS selectors.
We'd prefer users to avoid using Infima class names whenever possible, this is important is we want to support Tailwind for example, and still allow users to write selectors.
This is a first step in that direction, but is not exhaustive
Supersede #10843
Test Plan
CI + Argos + preview review
Test links
https://deploy-preview-10945--docusaurus-2.netlify.app/