feat(core): faster HTML minimizer - siteConfig.future.experimental_faster.swcHtmlMinimizer
#10554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -474 kB (-4.1%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@argos-ci/playwright@1.9.3, npm/@mdx-js/react@1.0.1, npm/@netlify/functions@1.6.0, npm/@playwright/test@1.47.2, npm/cheerio@1.0.0 |
siteConfig.future.experimental_faster.swcHtmlMinimizer
7 tasks
kdy1
pushed a commit
to swc-project/swc
that referenced
this pull request
Oct 6, 2024
**Description:** - `preserveComments` is optional but required in the TS type - `removeRedundantAttributes` is an enum and passing a boolean leads to errors See https://github.com/swc-project/swc/blob/main/crates/swc_html_minifier/src/option.rs#L54 **Related issue:** - facebook/docusaurus#10554
|
Answering @IntrepidToucan comment here directly on this PR to keep the Docusaurus Faster meta issue cleaner of this quite specific topic.
@IntrepidToucan Yes that's true, but it's considered an optimization built-in into the SWC minimizer by default. The following HTML is not malformed, it's spec compliant and pass W3C validation: <!doctype html>
<html lang=en>
<meta name=generator content="Docusaurus v3.7.0">
<title>Docusaurus changelog | Docusaurus</title>
<meta name=viewport content="width=device-width, initial-scale=1.0">
<body>
blablahttps://validator.w3.org/nu/#textarea
This is not considered a bug, so we'd need to understand what issue this is causing exactly. Maybe it's your other tool that doesn't support valid HTML markup that needs to be fixed instead. If you provide a good reason, I'm open to introducing a new option to let you configure or provide your own minimizer, but I need to understand the problem first. |
Hi @slorber , that makes sense. I'll bring this information back to the team so they can update their logic to accept this as valid HTML. Thanks for the helpful context and fast followup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docusaurus Faster
This PR is part of the Docusaurus Faster project aiming at reducing production build times
Motivation
The Docusaurus SSG step takes around ~7s, mainly because of HTML minification with
html-minifier-terserbeing slow.This PR add an opt-in for the new
@swc/htmlminifier, with the following results:Note: related SWC HTML minifier discussion: swc-project/swc#9616
Test Plan
CI + preview + argos
Test links
https://deploy-preview-10554--docusaurus-2.netlify.app/