chore(theme-translations): complete ko translations #7633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
cc @revi @koko8829 @winterlood Could you review this please? |
⚡️ Lighthouse report for the deploy preview of this PR
|
revi
reviewed
Jun 16, 2022
packages/docusaurus-theme-translations/locales/ko/plugin-ideal-image.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/ko/theme-common.json
Outdated
Show resolved
Hide resolved
Yeah, that's a bit annoying :/ Thanks for the review! |
winterlood
reviewed
Jun 16, 2022
packages/docusaurus-theme-translations/locales/ko/plugin-ideal-image.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/ko/theme-common.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/ko/theme-search-algolia.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/ko/theme-search-algolia.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/ko/plugin-ideal-image.json
Show resolved
Hide resolved
|
We can merge this if any of the reviewers can give a thumbs-up. |
Josh-Cena
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
All reviews seem cleared now—if any of you have further ideas of improvements feel free to follow up.
@HyunseungLee-Travis Thanks for your contribution!
@revi @winterlood Thanks for the review! I've credited you both as co-authors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
This PR translate some english texts still untranslated.
It also fixed some unnatural wordings.