8000 refactor: fix more type-aware linting errors by Josh-Cena · Pull Request #7479 · facebook/docusaurus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: fix more type-aware linting errors #7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2022
Merged

refactor: fix more type-aware linting errors #7479

merged 1 commit into from
May 24, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Continuation of #7477

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: ignore This PR is not meaningful enough to appear in the changelog. label May 24, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 24, 2022 10:59
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 24, 2022
@netlify
Copy link
netlify bot commented May 24, 2022 •
edited
Loading

✅ [V2]

Name Link
🔨 Latest commit 4dc03c1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628cbc2456e6e800098b14bb
😎 Deploy Preview https://deploy-preview-7479--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
github-actions bot commented May 24, 2022 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 85 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟢 90 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: -206 B (0%)

Total Size: 796 kB

Filename Size Change
website/build/assets/js/main.********.js 598 kB -206 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 106 kB
website/build/index.html 38.9 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 624735b into main May 24, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-lint branch May 24, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: ignore This PR is not meaningful enough to appear in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this 383E pull request may close these issues.
2 participants
@Josh-Cena @facebook-github-bot
0