8000 fix(core): all plugin lifecycles should receive translated content by Josh-Cena · Pull Request #7066 · facebook/docusaurus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(core): all plugin lifecycles should receive translated content #7066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix(core): all plugin lifecycles should receive translated content #7066

merged 1 commit into from
Mar 30, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Just realized our later lifecycles like configureWebpack and postBuild don't receive the translated content. Probably doesn't matter much but would be cool to have anyways

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Mar 30, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 30, 2022
@netlify
Copy link
netlify bot commented Mar 30, 2022

✅ [V2]

Name Link
🔨 Latest commit 916284e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6243d0eac1fa88000860c3b7
😎 Deploy Preview https://deploy-preview-7066--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 58
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7066--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 807 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 614 kB
website/build/index.html 38.4 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit fd24bd1 into main Mar 30, 2022
@Josh-Cena Josh-Cena deleted the jc/translate-content branch March 30, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @facebook-github-bot
0