fix(core): ensure stable webpack theme aliases sorting #6878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 8ae30b0 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6227dcc5dc718e0007aeb1f1 😎 Browse the preview: https://deploy-preview-6878--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6878--docusaurus-2.netlify.app/ |
Josh-Cena
reviewed
Mar 8, 2022
Josh-Cena
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The comparison function provided for themes is not consistent. The resulting array order is implementation-dependent, which means it could break between Node releases (unlikely, though) or if somebody tried to run this code in a browser somehow 😬
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
The only way to test this is by not using V8:
Before:
Chrome:
['@theme/Navbar', '@theme/NavbarItem/DefaultNavbarItem', '@theme/NavbarItem']Firefox:
[ "@theme/Navbar", "@theme/NavbarItem", "@theme/NavbarItem/DefaultNavbarItem"]After:
Chrome:
['@theme/Navbar', '@theme/NavbarItem/DefaultNavbarItem', '@theme/NavbarItem']Firefox:
[ "@theme/Navbar", "@theme/NavbarItem/DefaultNavbarItem", "@theme/NavbarItem" ]Related PRs
Current implementation introduced here: #5383