8000 fix(cli): disable directory listing in serve by Josh-Cena · Pull Request #6701 · facebook/docusaurus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(cli): disable directory listing in serve #6701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix(cli): disable directory listing in serve #6701

merged 1 commit into from
Feb 17, 2022

Conversation

Josh-Cena
Copy link
Collaborator
@Josh-Cena Josh-Cena commented Feb 17, 2022

Motivation

Fix #6699. This should be more in line with almost every hosting provider.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run yarn serve and go to http://localhost:3000/blog/2022. Before, it served

image

While now, it's the normal "page not found" page.

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Feb 17, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 17, 2022
@netlify
Copy link
netlify bot commented Feb 17, 2022

✔️ [V2]

🔨 Explore the source changes: 0554a6e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/620de1f2fb2ce100070bad55

😎 Browse the preview: https://deploy-preview-6701--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 51
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6701--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 781 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 48 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 590 kB
website/build/index.html 37.6 kB

compressed-size-action

@slorber
Copy link
Collaborator
slorber commented Feb 17, 2022

LGTM 👍

@slorber slorber merged commit 405d5d1 into main Feb 17, 2022
@slorber slorber deleted the jc/no-list branch February 17, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docusaurus serve: non-existent route displays default folder index view instead of 404 page
3 participants
0