8000 fix(theme-classic): minor BTT button fixes by lex111 · Pull Request #6652 · facebook/docusaurus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(theme-classic): minor BTT button fixes #6652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2022
Merged

fix(theme-classic): minor BTT button fixes #6652

merged 1 commit into from
Feb 10, 2022

Conversation

lex111
Copy link
Contributor
@lex111 lex111 commented Feb 10, 2022

Motivation

  • Disable tabbing on hidden BTT button
  • Put BTT button under overlay of mobile doc sidebar
Before After
image image

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Feb 10, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 10, 2022
@netlify
Copy link
netlify bot commented Feb 10, 2022

✔️ [V2]

🔨 Explore the source changes: 6af730e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6204e77444107400071d89f2

😎 Browse the preview: https://deploy-preview-6652--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 93
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6652--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +47 B (0%)

Total Size: 773 kB

Filename Size Change
website/build/assets/css/styles.********.css 105 kB +47 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 47.8 kB
website/build/assets/js/main.********.js 583 kB
website/build/index.html 36.7 kB

compressed-size-action

Josh-Cena
Josh-Cena approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator
@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@slorber slorber merged commit 10a5f71 into main Feb 10, 2022
@slorber slorber deleted the lex111/btt-fixes branch February 10, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lex111 @Josh-Cena @slorber @facebook-github-bot
0