8000 feat(create): allow specifying a git clone strategy by Josh-Cena · Pull Request #6610 · facebook/docusaurus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(create): allow specifying a git clone strategy #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2022
Merged

feat(create): allow specifying a git clone strategy #6610

merged 2 commits into from
Feb 10, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

As requested on Canny: https://docusaurus.canny.io/feature-requests/p/improve-template-cloning

This PR adds a customizable git clone strategy, allowing the user to use shallow, copy, or even bring in their own git clone options.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tested locally

@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Feb 5, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 5, 2022
@netlify
Copy link
netlify bot commented Feb 5, 2022 •
edited
Loading

✔️ [V2]

🔨 Explore the source changes: 805eff2

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/62047e6bc5c3e000086d7988

😎 Browse the preview: https://deploy-preview-6610--docusaurus-2.netlify.app

@github-actions
Copy link
github-actions bot commented Feb 5, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 93
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6610--docusaurus-2.netlify.app/

@github-actions
Copy link
github-actions bot commented Feb 5, 2022 •
edited
Loading

Size Change: +2.05 kB (0%)

Total Size: 773 kB

Filename Size Change
website/.docusaurus/globalData.json 47.8 kB +587 B (+1%)
website/build/assets/js/main.********.js 583 kB +1.46 kB (0%)
ℹ️ View Unchanged
Filename Size
website/build/assets/css/styles.********.css 105 kB
website/build/index.html 36.7 kB

compressed-size-action

slorber
slorber approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator
@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ why not

packages/create-docusaurus/src/index.ts Outdated
}
case 'deep':
default:
return 'git clo';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@Josh-Cena Josh-Cena merged commit b16b394 into main Feb 10, 2022
@Josh-Cena Josh-Cena deleted the jc/create-git-strategy branch February 10, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber slorber approved these changes

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Josh-Cena @slorber @facebook-github-bot
0