8000 fix(cli): log error itself on unhandled rejection by Josh-Cena · Pull Request #6607 · facebook/docusaurus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(cli): log error itself on unhandled rejection #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2022
Merged

fix(cli): log error itself on unhandled rejection #6607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docusaurus/bin/docusaurus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,6 @@ async function run() {
run();

process.on('unhandledRejection', (err) => {
logger.error(err.stack);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have error.stack logged in multiple other places of the codebase, should we clean those up too?

Does it work correctly with toString/string interpolation logs?

Not sure why exactly, I think Node.js didn't log properly in older versions? 🤷‍♂️

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why either. Errors can both be stringified and logged very nicely. And yeah, I'll probably clean up the rest later

logger.error(err);
process.exit(1);
});
0